Fix - remove isomorphic-webcrypto polyfill and add buffer polyfill to react native#235
Merged
1 commit merged intomasterpubnub/javascript:masterfrom Dec 9, 2021
Merged
Fix - remove isomorphic-webcrypto polyfill and add buffer polyfill to react native#2351 commit merged intomasterpubnub/javascript:masterfrom
1 commit merged intomasterpubnub/javascript:masterfrom
Conversation
are
reviewed
Dec 9, 2021
| "buffer": "^6.0.3", | ||
| "cbor-js": "^0.1.0", | ||
| "cbor-sync": "^1.0.4", | ||
| "isomorphic-webcrypto": "^2.3.6", |
Contributor
There was a problem hiding this comment.
Are you sure this has no impact on browser builds?
Author
There was a problem hiding this comment.
Yes, there will be no impact to our supported platforms. For very old browser versions and for internet explorer, the change will impact support for file encryption. Customers who support those old browsers will be able to bring their own web cryptography polyfill to their applications in order to add the support since we will no longer bundle it.
are
approved these changes
Dec 9, 2021
Contributor
are
left a comment
There was a problem hiding this comment.
If it works on all platforms, then it LGTM!
Author
|
@client-engineering-bot release as v4.36.0 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove isomorphic-webcrypto polyfill and add buffer polyfill to react native
Remove isomorphic-webcrypto polyfill for web
Add buffer polyfill to react native
Closes #233