Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

develop to master#149

Merged
davidnub merged 33 commits intomasterpubnub/javascript:masterfrom
developpubnub/javascript:developCopy head branch name to clipboard
Jun 13, 2019
Merged

develop to master#149
davidnub merged 33 commits intomasterpubnub/javascript:masterfrom
developpubnub/javascript:developCopy head branch name to clipboard

Conversation

@budgetpreneur
Copy link
Contributor

No description provided.

davidnub and others added 26 commits April 26, 2019 17:45
* fix(subscribe): return 'state' query parameter back

Return 'state' back for subscribe endpoint, so client will maintain state information
even when heartbeat disabled.
@budgetpreneur budgetpreneur requested a review from davidnub June 13, 2019 15:39
@pubnub pubnub deleted a comment Jun 13, 2019
@pubnub pubnub deleted a comment Jun 13, 2019
@pubnub pubnub deleted a comment Jun 13, 2019
@pubnub pubnub deleted a comment Jun 13, 2019
@pubnub pubnub deleted a comment Jun 13, 2019
@pubnub pubnub deleted a comment Jun 13, 2019
Copy link
Contributor

@davidnub davidnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@davidnub davidnub merged commit c51488e into master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.