Develop#129
Merged
ManuelFernando merged 28 commits intomasterpubnub/javascript:masterfrom Apr 27, 2018
Merged
Conversation
* Add NativeScript support * Add tests for NativeScript * Replace React-Native with NativeScript in NativeScript tests * Fix support for nativescript * Add tasks for to gulpfile for nativescript * Create dist for nativescript * Update .gitignore for nativescript * Remove NativeScript dist bundle * Use NativeScript http module * Remove some Gulp tasks related to NativeScript * Update compiled modules * Update dist bundles * Replace all uses of uuid with lil-uuid * Fix error detection for NartiveScript network module * Check if abort is a function before calling it Some platforms don't return an object that contains an abort function to cancel network requests. This change checks if an abort function is available before calling it. * Update all the builds * add entry point to app with Native Script * resolve eslint issues * add operation delete to native script * remove multi-spaces
set ssl to true for nodejs by default
* isHeartbeatOnAllSubscriptions * remove isHeartbeatOnAllSubscriptions from the config * start only the heartbeat loop with heartbeatChannels and heartbeatChannelGroup
CliftonH
reviewed
Apr 25, 2018
|
|
||
| // reset the current timetoken to get a connect event. | ||
| if (this._currentTimetoken !== '0') { | ||
| if (this._currentTimetoken !== '0' && this._currentTimetoken !== 0) { |
Contributor
There was a problem hiding this comment.
Is there a scenario where this value set to '0'?
Contributor
There was a problem hiding this comment.
there may be a case of when the service responds with a 0 timetoken but switching the region.
MaxPresman
approved these changes
Apr 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.