Return in callback PNReconnectedCategory status for reconnect method#227
Merged
Return in callback PNReconnectedCategory status for reconnect method#227
Conversation
bartk
reviewed
Nov 29, 2021
| unsubscribe((UnsubscribeOperation) pubSubOperation); | ||
| stateChanged = true; | ||
| shouldAnnounce = true; | ||
| announceStatus = PNStatusCategory.PNConnectedCategory; |
Contributor
Author
There was a problem hiding this comment.
We are notifying users that we're still connected after they unsubscribe from some channels assuming that at least one has left. In case they unsubscribed from everything that won't have any effect
There was a problem hiding this comment.
Shouldn't it be PNReconnectedCategory instead of PNConnectedCategory ?
Contributor
Author
There was a problem hiding this comment.
It was previously PNConnectedCategory so I kept it the same way
bartk
previously approved these changes
Dec 7, 2021
Contributor
Author
|
@client-engineering-bot release |
kazydek
approved these changes
Dec 9, 2021
bartk
approved these changes
Dec 10, 2021
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Emit PNReconnectedCategory in case of successful manual reconnection