Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

SDK-1549 Reconnect restarts subscribe loop regardless of the state#220

Merged
kleewho merged 2 commits intomasterpubnub/java:masterfrom
SDK-1549pubnub/java:SDK-1549Copy head branch name to clipboard
Nov 4, 2021
Merged

SDK-1549 Reconnect restarts subscribe loop regardless of the state#220
kleewho merged 2 commits intomasterpubnub/java:masterfrom
SDK-1549pubnub/java:SDK-1549Copy head branch name to clipboard

Conversation

@kleewho
Copy link
Contributor

@kleewho kleewho commented Oct 29, 2021

fix: Reconnect always restarts the subscription connection

bartk
bartk previously approved these changes Oct 29, 2021
Copy link
Contributor

@bartk bartk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there is one question.

@kleewho
Copy link
Contributor Author

kleewho commented Nov 4, 2021

@client-engineering-bot help

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

@kleewho some information which may help you listed below.

Available commands and options

List of comments which can trigger deployment action:

  • @client-engineering-bot help to get this information
  • @client-engineering-bot release [<project>] [as [<version>]] complete preparation before merge to default branch.
    • project - optional identifier of project from .github/workflows/release/products.json which should be released.
      By default repository root will be used.
    • version - optional custom version with which release should be done.
      By default next version is based on changes mentioned in initial PR comment.

@kleewho
Copy link
Contributor Author

kleewho commented Nov 4, 2021

@client-engineering-bot release

@kleewho kleewho merged commit 88ab518 into master Nov 4, 2021
@kleewho kleewho deleted the SDK-1549 branch November 4, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.