Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Do not set headers with None value #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kennethreitz merged 1 commit into from
Mar 3, 2014
Merged

Do not set headers with None value #1921

kennethreitz merged 1 commit into from
Mar 3, 2014

Conversation

@sigmavirus24
Copy link
Contributor

@sigmavirus24 sigmavirus24 commented Feb 14, 2014

@sigmavirus24
Do not set headers with None value
d2f647c 
- Regardless of whether they are on the session or not
- Fixes psf#1920
@sigmavirus24
Copy link
Contributor Author

sigmavirus24 commented Feb 14, 2014

Assigning to @Lukasa for review and once past that, I will assign it to Kenneth.

@Lukasa
Copy link
Member

Lukasa commented Feb 14, 2014

LGTM. 👍

@Lukasa Lukasa assigned kennethreitz and unassigned Lukasa Feb 14, 2014
@sigmavirus24
Copy link
Contributor Author

sigmavirus24 commented Feb 14, 2014

FWIW, I think we used to do this back in 1.x but someone recently rewrote the merge_setting function (also they moved which file it is in so I couldn't find it at first =P) and they dropped this functionality. This is a backwards regression but I can understand if we'd rather let the user shoot themselves in the foot.

kennethreitz added a commit that referenced this pull request Mar 3, 2014
@kennethreitz
Merge pull request #1921 from sigmavirus24/fix-session-header-none
3c4b374 
Do not set headers with None value
@kennethreitz kennethreitz merged commit 3c4b374 into psf:master Mar 3, 2014
@kennethreitz
Copy link
Contributor

kennethreitz commented Mar 3, 2014

🍰

@sigmavirus24 sigmavirus24 deleted the fix-session-header-none branch March 5, 2014 01:42
@sigmavirus24
Copy link
Contributor Author

sigmavirus24 commented Mar 5, 2014

☕

@ak1r4 ak1r4 mentioned this pull request Aug 4, 2015
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kennethreitz kennethreitz

Labels

Minion Seal of Approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Removing a default header of a session

3 participants

@sigmavirus24 @Lukasa @kennethreitz
Morty Proxy This is a proxified and sanitized view of the page, visit original site.