Breaking change: Add a debug check that the target of CopyFrom is not a descendant of the source. #24004
+0
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a descendant of the source. Previously, you were allowed to do the following: ```cc MyMessage msg; *msg.mutable_submessage() = msg; ``` However, this could leave the message in an inconsistent state in some contrived examples, and the order of operations is unclear and potentially compiler-dependent. Instead, if you would like to do this, you should be explicit about the order of operations: ```cc MyMessage msg; MyMessage msg_copy = msg; *msg.mutable_submessage() = std::move(msg_copy); ``` PiperOrigin-RevId: 820018061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: Add a debug check that the target of CopyFrom is not a descendant of the source.
Previously, you were allowed to do the following:
However, this could leave the message in an inconsistent state in some contrived examples, and the order of operations is unclear and potentially compiler-dependent.
Instead, if you would like to do this, you should be explicit about the order of operations: