Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 09985f8

Browse filesBrowse files
honglookercopybara-github
authored andcommitted
hpb: migrate generator.cc from .EmitLegacy to .Emit
PiperOrigin-RevId: 758202304
1 parent 24da3b2 commit 09985f8
Copy full SHA for 09985f8

File tree

1 file changed

+18
-17
lines changed
Filter options

1 file changed

+18
-17
lines changed

‎hpb_generator/generator.cc

Copy file name to clipboardExpand all lines: hpb_generator/generator.cc
+18-17
Original file line numberDiff line numberDiff line change
@@ -87,25 +87,24 @@ void WriteHeader(const protobuf::FileDescriptor* file, Context& ctx) {
8787
return;
8888
}
8989
EmitFileWarning(file, ctx);
90-
ctx.EmitLegacy(
91-
R"cc(
92-
#ifndef $0_HPB_PROTO_H_
93-
#define $0_HPB_PROTO_H_
90+
ctx.Emit({{"filename", ToPreproc(file->name())}},
91+
R"cc(
92+
#ifndef $filename$_HPB_PROTO_H_
93+
#define $filename$_HPB_PROTO_H_
9494
9595
#include "google/protobuf/hpb/repeated_field.h"
9696
9797
#include "absl/status/statusor.h"
9898
#include "absl/strings/string_view.h"
99-
)cc",
100-
ToPreproc(file->name()));
99+
)cc");
101100

102101
// Import headers for proto public dependencies.
103102
for (int i = 0; i < file->public_dependency_count(); i++) {
104103
if (i == 0) {
105104
ctx.Emit("// Public Imports.\n");
106105
}
107-
ctx.EmitLegacy("#include \"$0\"\n",
108-
CppHeaderFilename(file->public_dependency(i)));
106+
ctx.Emit({{"header", CppHeaderFilename(file->public_dependency(i))}},
107+
"#include \"$header$\"\n");
109108
if (i == file->public_dependency_count() - 1) {
110109
ctx.Emit("\n");
111110
}
@@ -146,7 +145,8 @@ void WriteHeader(const protobuf::FileDescriptor* file, Context& ctx) {
146145
ctx.Emit("\n#include \"upb/port/undef.inc\"\n\n");
147146
// End of "C" section.
148147

149-
ctx.EmitLegacy("#endif /* $0_HPB_PROTO_H_ */\n", ToPreproc(file->name()));
148+
ctx.Emit({{"filename", ToPreproc(file->name())}},
149+
"#endif /* $filename$_HPB_PROTO_H_ */\n");
150150
}
151151

152152
// Writes a .hpb.cc source file.
@@ -157,24 +157,24 @@ void WriteSource(const protobuf::FileDescriptor* file, Context& ctx) {
157157
}
158158
EmitFileWarning(file, ctx);
159159

160-
ctx.EmitLegacy(
161-
R"cc(
160+
ctx.Emit({{"header", CppHeaderFilename(file)}},
161+
R"cc(
162162
#include <stddef.h>
163163
#include "absl/log/absl_check.h"
164164
#include "absl/strings/string_view.h"
165-
#include "$0"
166-
)cc",
167-
CppHeaderFilename(file));
165+
#include "$header$"
166+
)cc");
168167

169168
for (int i = 0; i < file->dependency_count(); i++) {
170169
if (ctx.options().strip_feature_includes &&
171170
compiler::IsKnownFeatureProto(file->dependency(i)->name())) {
172171
// Strip feature imports for editions codegen tests.
173172
continue;
174173
}
175-
ctx.EmitLegacy("#include \"$0\"\n", CppHeaderFilename(file->dependency(i)));
174+
ctx.Emit({{"header", CppHeaderFilename(file->dependency(i))}},
175+
"#include \"$header$\"\n");
176176
}
177-
ctx.EmitLegacy("#include \"upb/port/def.inc\"\n");
177+
ctx.Emit("#include \"upb/port/def.inc\"\n");
178178

179179
WrapNamespace(file, ctx, [&]() { WriteMessageImplementations(file, ctx); });
180180

@@ -217,7 +217,8 @@ void WriteTypedefForwardingHeader(
217217
void WriteHeaderMessageForwardDecls(const protobuf::FileDescriptor* file,
218218
Context& ctx) {
219219
// Import forward-declaration of types defined in this file.
220-
ctx.EmitLegacy("#include \"$0\"\n", UpbCFilename(file));
220+
ctx.Emit({{"upb_filename", UpbCFilename(file)}},
221+
"#include \"$upb_filename$\"\n");
221222
WriteForwardDecls(file, ctx);
222223
// Import forward-declaration of types in dependencies.
223224
for (int i = 0; i < file->dependency_count(); ++i) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.