feat: support VictoriaMetrics MetricsQL#8469
feat: support VictoriaMetrics MetricsQL#8469robbat2 wants to merge 3 commits intoprometheus-operator:mainprometheus-operator/prometheus-operator:mainfrom robbat2:rjohnson/MetricsQLrobbat2/prometheus-operator:rjohnson/MetricsQLCopy head branch name to clipboard
Conversation
The admissiion webhook presently rejects VictoriaMetric's dialect of PromQL: MetricsQL. Make it a configurable option to accept in the cluster, where PrometheusRule is being used and converted into VictoriaMetrics resources. Without this patch, you cannot use PrometheusRule resources that contain MetricsQL expressions unless the admission webhook is disabled, which is not desirable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
f4a3cf0 to
e10aa2a
Compare
|
While the change is minimal, I'm reluctant incurring support cose for something that's not core to the project. I would have assumed that you'd use VM operator's CRDs (https://docs.victoriametrics.com/operator/api/#vmrule). What's the scenario where you prefer using Prometheus operator CRDs? |
|
@simonpasquier - many existing Helm Charts ship with out of the box PrometheusRules, and may bundle prometheus-operator as well; this enables the smallest lift for those environments that happen to have VictoriaMetrics behind them. The VM Operator validating webhook also doesn't validate PrometheusRule today [it does validate VMRule] - I have a draft change to implement that where it would be more appropriate as well; but want to be able to catch this quicker |
Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com> Reference: prometheus-operator#8469 (comment)
|
Sorry, I still don't understand the use case: if you use the MetricsQL variant for rules then it falls under the responsibility of the VM operator from my perspective. |
The admission webhook presently rejects VictoriaMetric's dialect of PromQL:
MetricsQL. Make it a configurable option to accept in the cluster, where
PrometheusRule is being used and converted into VictoriaMetrics resources.
Without this patch, you cannot use PrometheusRule resources that contain
MetricsQL expressions unless the admission webhook is disabled, which is not
desirable.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Signed-off-by: Robin H. Johnson rjohnson@coreweave.com