Modify the way of starting service #891
Closed
SilenceAdele wants to merge 2 commits intoprometheus:masterprometheus/client_python:masterfrom
Closed
Modify the way of starting service #891SilenceAdele wants to merge 2 commits intoprometheus:masterprometheus/client_python:masterfrom
SilenceAdele wants to merge 2 commits intoprometheus:masterprometheus/client_python:masterfrom
Conversation
SilenceAdele
commented
Feb 16, 2023
- Modify the way of starting service
* Add start service script Signed-off-by: Zhou Zhiyuan <zhiyuan.zhou@easystack.cn>
Modify the way of starting service * Modify the way of starting service Signed-off-by: Zhou Zhiyuan <zhiyuan.zhou@easystack.cn> Signed-off-by: SilenceAdele <57695174+SilenceAdele@users.noreply.github.com>
Member
csmarchbanks
left a comment
There was a problem hiding this comment.
Hello, thank you for your PR!
I am not sure I like forcing a user to clone this repository to run the quickstart example, having it embedded in the README is nice for that. Is there a reason you like the separate file more?
Author
|
ok，I konw that what you mean. |
Member
|
Closing as I like the current documentation more. Happy to reconsider if there are additional reasons to separate the example into a file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.