Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Make tests pass on Python 2.6#89

Merged
brian-brazil merged 1 commit intoprometheus:masterprometheus/client_python:masterfrom
hynek:masterCopy head branch name to clipboard
Jul 14, 2016
Merged

Make tests pass on Python 2.6#89
brian-brazil merged 1 commit intoprometheus:masterprometheus/client_python:masterfrom
hynek:masterCopy head branch name to clipboard

Conversation

@hynek
Copy link
Contributor

@hynek hynek commented Jul 8, 2016

As discussed in #86, this adds Python 2.6 support for the tests and CI.

Since 2.6’s stdlib doesn’t support test skipping, we have to resort to using the back port unittest2.

There are a few ways to make it less ugly:

  • use unittest2 unconditionally everywhere. has also the benefit of a consistent test environment.
  • do the dance once in a helper module (say tests/utils.py) and then just import unittest from there.
  • use pytest for skipping

@brian-brazil brian-brazil merged commit bc2f2bc into prometheus:master Jul 14, 2016
@brian-brazil
Copy link
Contributor

Having anyone on 2.6 have to install an extra module for testing seems fine to me.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.