Make tests pass on Python 2.6#89
Merged
brian-brazil merged 1 commit intoprometheus:masterprometheus/client_python:masterfrom Jul 14, 2016
hynek:masterCopy head branch name to clipboard
Merged
Make tests pass on Python 2.6#89brian-brazil merged 1 commit intoprometheus:masterprometheus/client_python:masterfrom hynek:masterCopy head branch name to clipboard
brian-brazil merged 1 commit intoprometheus:masterprometheus/client_python:masterfrom
hynek:masterCopy head branch name to clipboard
Conversation
Contributor
|
Having anyone on 2.6 have to install an extra module for testing seems fine to me. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #86, this adds Python 2.6 support for the tests and CI.
Since 2.6’s stdlib doesn’t support test skipping, we have to resort to using the back port unittest2.
There are a few ways to make it less ugly:
tests/utils.py) and then just import unittest from there.