return httpd.server_address so that ephemeral ports can be surfaced#574
Closed
cwells wants to merge 1 commit intoprometheus:masterprometheus/client_python:masterfrom
Closed
return httpd.server_address so that ephemeral ports can be surfaced#574cwells wants to merge 1 commit intoprometheus:masterprometheus/client_python:masterfrom
cwells wants to merge 1 commit intoprometheus:masterprometheus/client_python:masterfrom
Conversation
Signed-off-by: Cliff Wells <cliff.wells@gmail.com>
Contributor
|
Thanks for your PR. start_http_server is intended to be a way to get up and running quickly, rather than a full on solution. If you need something more niche I'd recommend using your own http server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our platform consists of hundreds of Python agents running on EC2 instances in an ASG that we wish to monitor with Prometheus. The agents will generally be long-running (days, weeks, months), but can be killed or migrated to another node without warning.
Because of this, it is not possible to use a fixed port number for exposing the Prometheus endpoint. However, we can pass
0as the port number and let the OS find an ephemeral port to listen on. Unfortunately there doesn't seem to be a way to surface the resulting port number back to the agent so that we can then populate Consul and let Prometheus know where to scrape data from.This PR addresses this shortcoming.