Add checks for various other float formats.#460
Merged
brian-brazil merged 1 commit intomasterprometheus/client_python:masterfrom Sep 9, 2019
Merged
Add checks for various other float formats.#460brian-brazil merged 1 commit intomasterprometheus/client_python:masterfrom
brian-brazil merged 1 commit intomasterprometheus/client_python:masterfrom
Conversation
Check for new stuff Go added in 1.13, and also make sure leading 0s are permitted as some users want to be able to do fixed-size output. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
3eafa33 to
4e97964
Compare
Contributor
Author
|
Tests caught that Python 3 also supported some of this, so fixed that too. |
Arfey
pushed a commit
to Arfey/client_python
that referenced
this pull request
Sep 13, 2019
Check for new stuff Go added in 1.13, and also make sure leading 0s are permitted as some users want to be able to do fixed-size output. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io> Signed-off-by: misha.gavela <Arfey17.mg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for new stuff Go added in 1.13, and also
make sure leading 0s are permitted as some users
want to be able to do fixed-size output.
@SuperQ