very small change to fix errors when handling datetime object from aws#422
Closed
wuarthur wants to merge 1 commit intoprometheus:masterprometheus/client_python:masterfrom
Closed
very small change to fix errors when handling datetime object from aws#422wuarthur wants to merge 1 commit intoprometheus:masterprometheus/client_python:masterfrom
wuarthur wants to merge 1 commit intoprometheus:masterprometheus/client_python:masterfrom
Conversation
c4272c5 to
dba69f0
Compare
Signed-off-by: Arthur Yang <yaqixyz@gmail.com>
Contributor
|
Can you add a unittest for this? |
Contributor
|
This has gone stale, let us know if you still want to work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am trying to export CreateDate using the aws-prometheus-exporter the exporter fails because of an error in [exposition.py ]
there seems to be an type error in this function, when v is expected to be a string, however sometimes aws return datas as an datetime object, which cause
v.replace('\\', r'\\')errors out.i found that this can be fixed by minimally changing line 78 in exposition.py to
k, str(v).replace('\\', r'\\').replace('\n', r'\n').replace('"', r'\"'))