debug MetricWrapperBase.remove function#386
Closed
leileiwan wants to merge 6 commits intoprometheus:masterprometheus/client_python:masterfrom
Closed
debug MetricWrapperBase.remove function#386leileiwan wants to merge 6 commits intoprometheus:masterprometheus/client_python:masterfrom
leileiwan wants to merge 6 commits intoprometheus:masterprometheus/client_python:masterfrom
Conversation
Contributor
|
This sort of printlining does not belong in a library like this. I'd suggest not putting in data you don't want to be there in the first place. |
Author
|
yes,you are right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello，I am using client_python for developing our exporter，thanks for so convenient tool.
In our project, we don't want some of our metrics to be captured, so we should use MetricWrapperBase's remove function.But when self._metrics is empty or "labelvalues" not in self._metrics, our exporter will stop because of "key error". As a user of the tool,I want some more information not just key error.what's worse,I don't want my exporter to be stoped. It would be better if just some warnings, because we have to be sure that some values of labels are not captured, but we cannot be sure that whether the value-tuples are in self._metrics or not.