Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

start_http_server for any given registry or the default registry#143

Closed
danni-m wants to merge 1 commit intoprometheus:masterprometheus/client_python:masterfrom
danni-m:masterdanni-m/client_python:masterCopy head branch name to clipboard
Closed

start_http_server for any given registry or the default registry#143
danni-m wants to merge 1 commit intoprometheus:masterprometheus/client_python:masterfrom
danni-m:masterdanni-m/client_python:masterCopy head branch name to clipboard

Conversation

@danni-m
Copy link

@danni-m danni-m commented Feb 20, 2017

I'm using start_http_server, but unfortunately it only exposes the default registry, all other exposition methods have a registry parameter.

@brian-brazil

@brian-brazil
Copy link
Contributor

You should only ever be exposing the default registry via this method. If you're doing something funky (such as what the snmp or blackbox exporters do), you'll need custom handling anyway.

@danni-m
Copy link
Author

danni-m commented Feb 20, 2017

What I want is to expose 2 different registries on 2 different ports.
start_wsgi_server allows to receive a specific registry while start_http_server doesn't.

How those 2 functions differ except WSGI/SimpleHTTPServer ?

@brian-brazil
Copy link
Contributor

What I want is to expose 2 different registries on 2 different ports.

Why do you want to do this?

A single process should have a single registry.

@danni-m
Copy link
Author

danni-m commented Feb 20, 2017

Is there any reason why start_wsgi_server should be different than start_http_server?

@brian-brazil
Copy link
Contributor

There isn't, that parameter should be removed.

@danni-m
Copy link
Author

danni-m commented Feb 23, 2017

@brian-brazil would you accept a PR that removes the parameter?

@brian-brazil
Copy link
Contributor

I would.

@danni-m danni-m closed this Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.