Add support for exporting metrics to a pushgateway#13
Add support for exporting metrics to a pushgateway#13mmoya wants to merge 6 commits intoprometheus:masterprometheus/client_python:masterfrom mmoya:push-to-gatewayCopy head branch name to clipboard
Conversation
prometheus_client/__init__.py
Outdated
There was a problem hiding this comment.
As painful as it is, we should stick to urllib for the broadest possible compatibility. I want to avoid any dependencies outside of core cpython, so that there's no friction to instrumenting code.
|
I've been holding off on adding this until prometheus/pushgateway#18 is resolved, as the 'instance' handling isn't quite compatible with the usual use cases. |
|
Resubmitted using |
README.md
Outdated
There was a problem hiding this comment.
This should all be one method
|
I messed this up, deleted the branch by accident and that closed the PR. |
|
@brian-brazil @mmoya - just noticed this PR sitting here for almost a month - is it still current? |
|
This is still current, we're waiting on the instance label cleanup on the push_gateway side. |
|
Any idea when this might land? Would love to see that functionality. |
|
Looks like we're pretty close to having all the required changes elsewhere. This needs to be updated to set the |
There was a problem hiding this comment.
This should be prefixed with _ to mark it as internal
Wait, that's not right. No change required there as the pushgateway handles that. You'll need up pull in the latest changes to the repo, and things have been split into separate files. |
|
I've updated this and merged it. Thanks! |
Add support for exporting metrics to a pushgateway. By default the fqdn is sent is instance wasn't provided.