fix: Use asyncio.new_event_loop() to create event loop for tests#1138
Merged
csmarchbanks merged 2 commits intoprometheus:masterprometheus/client_python:masterfrom Sep 12, 2025
Merged
fix: Use asyncio.new_event_loop() to create event loop for tests#1138csmarchbanks merged 2 commits intoprometheus:masterprometheus/client_python:masterfrom
asyncio.new_event_loop() to create event loop for tests#1138csmarchbanks merged 2 commits intoprometheus:masterprometheus/client_python:masterfrom
Conversation
Replace the use of `asyncio.get_event_loop()` with more appropriate `asyncio.new_event_loop()` to create event loops for testing. The former used to be a wrapper that either returned the currently running event loop or created a new one, but the latter behavior was deprecated and removed in Python 3.14. Since the tests are always run in a synchronous context, and they always run the obtained event loop to completion, just always create a new event loop. Fixes prometheus#1137 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Remove the `asgiref` pin linked to prometheus#1020. I can't reproduce the issue anymore with the current `asgiref` versions, and the pin actually breaks the tests with the `asyncio` event loop fixes. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Contributor
Author
csmarchbanks
approved these changes
Sep 12, 2025
Member
|
Thank you! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the use of
asyncio.get_event_loop()with more appropriateasyncio.new_event_loop()to create event loops for testing. The former used to be a wrapper that either returned the currently running event loop or created a new one, but the latter behavior was deprecated and removed in Python 3.14. Since the tests are always run in a synchronous context, and they always run the obtained event loop to completion, just always create a new event loop.Fixes #1137