Could io.prometheus:simpleclient_hibernate:0.10.1-SNAPSHOT drop off redundant dependencies to loose weight?#655
Closed
Celebrate-future wants to merge 1 commit intoprometheus:masterprometheus/client_java:masterfrom
Closed
Could io.prometheus:simpleclient_hibernate:0.10.1-SNAPSHOT drop off redundant dependencies to loose weight?#655Celebrate-future wants to merge 1 commit intoprometheus:masterprometheus/client_java:masterfrom
Celebrate-future wants to merge 1 commit intoprometheus:masterprometheus/client_java:masterfrom
Conversation
Member
|
Thanks for the PR. The hibernate dependency has Do you see any difference in the size of the resulting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fstab Hi, I am a user of project io.prometheus:simpleclient_hibernate:0.10.1-SNAPSHOT. I found that its pom file introduced 24 dependencies. However, among them, 7 libraries (29%) have not been used by your project (the redundant dependencies are listed below). Reduce these useless dependencies can help prevent conflicts between library versions. MeanWhile, it can minimize the total added size to projects. It can also help enable advanced scenarios for users of your package.
This PR helps io.prometheus:simpleclient_hibernate:0.10.1-SNAPSHOT lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.
Best regards
Redundant dependencies----