Support direct access to com.sun.management.OperatingSystemMXBean#278
Closed
PaulSandoz wants to merge 1 commit intoprometheus:masterprometheus/client_java:masterfrom
Closed
Support direct access to com.sun.management.OperatingSystemMXBean#278PaulSandoz wants to merge 1 commit intoprometheus:masterprometheus/client_java:masterfrom
PaulSandoz wants to merge 1 commit intoprometheus:masterprometheus/client_java:masterfrom
Conversation
reflective access to com.ibm.lang.management.OperatingSystemMXBean.
Contributor
|
This looks okay to me in principle. @davidkarlsen Can you confirm this still works on IBM Java? |
Contributor
|
A bit disconnected from the grid until the weekend - if it compiles with an IBM JDK 7/8 (or whatever lower-boundary for JDK version) it should be ok - but I suspect the class might not be present on an IBM JDK. |
Contributor
|
Superseded by #281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obtaining the counter metric process_cpu_seconds_total fails on Java 9 because the setAccessible call throws an Exception. This is because the reflective method is obtained from the concrete implementing class rather than the interface. In Java 9 classes may be encapsulated within a module and not exported and therefore not accessible.
We can check that the OS bean is an instance of com.sun.management.OperatingSystemMXBean (as is already done for com.sun.management.UnixOperatingSystemMXBean, the latter inherits from the former).
For interface com.ibm.lang.management.OperatingSystemMXBean we still need to perform reflective access but we should operate on the method whose declaring class is that interface to ensure access (note i have not tested this since i don't have a distribution of the IBM JDK).