add branch coverage, better javadoc lints#1851
Merged
zeitlinger merged 4 commits intomainprometheus/client_java:mainfrom Feb 6, 2026
Merged
add branch coverage, better javadoc lints#1851zeitlinger merged 4 commits intomainprometheus/client_java:mainfrom
zeitlinger merged 4 commits intomainprometheus/client_java:mainfrom
Conversation
ca6293c to
45eeb41
Compare
jaydeluca
approved these changes
Feb 6, 2026
Collaborator
jaydeluca
left a comment
There was a problem hiding this comment.
🎉 out of curiosity, do you happen to know the test coverage % before and after this?
| ExporterPushgatewayProperties properties = | ||
| load( | ||
| Map.of( | ||
| "io.prometheus.exporter.pushgateway.connectTimeoutSeconds", "5", |
Collaborator
There was a problem hiding this comment.
i know these are backwards compatible, but just noting we probably want to update these after #1828 is merged
Member
Author
There was a problem hiding this comment.
good catch! We can wait with this PR - it's not urgent.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Add comprehensive tests for classes that were below coverage requirements: - Config module: ExporterProperties, ExporterOpenTelemetryProperties, ExporterPushgatewayProperties - Exposition formats: PrometheusProtobufWriter - HTTP server: HTTPServer authentication, HttpExchangeAdapter - OpenTelemetry: HistogramPointDataImpl, ExponentialHistogramPointDataImpl - Pushgateway: Scheme - JVM instrumentation: JvmMemoryPoolAllocationMetrics Exclude two classes from coverage checks that require complex mocking: - AllocationCountingNotificationListener (GC notifications) - MapperConfig (complex configuration branching) All coverage checks now pass, resolving branch coverage violations. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
45eeb41 to
cb5eb56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.