fix and test gh pages#1845
Merged
zeitlinger merged 4 commits intomainprometheus/client_java:mainfrom Feb 4, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
jaydeluca
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes GitHub Pages generation by refactoring the Hugo schema.org JSON-LD template and adds GitHub Pages build testing to the test-release-build workflow.
Changes:
- Refactored Hugo microformats schema template from manual JSON construction to using Hugo's
dictandjsonifyfunctions - Added fetch-tags and fetch-depth configuration to enable git tag access in the workflow
- Changed workflow job from building only Javadoc to building the complete GitHub Pages site
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/themes/hugo-geekdoc/layouts/partials/microformats/schema.html | Refactored JSON-LD structured data generation to use dict/jsonify instead of manual JSON construction, fixing quoting issues |
| .github/workflows/test-release-build.yml | Added GitHub Pages build testing with git tag fetching support and BASE_URL configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/themes/hugo-geekdoc/layouts/partials/microformats/schema.html
Outdated
Show resolved
Hide resolved
…html Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.