improve code quality, part 1#1808
Merged
zeitlinger merged 10 commits intomainprometheus/client_java:mainfrom Jan 26, 2026
Merged
improve code quality, part 1#1808zeitlinger merged 10 commits intomainprometheus/client_java:mainfrom
zeitlinger merged 10 commits intomainprometheus/client_java:mainfrom
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
…xports and reducing code duplication Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
jaydeluca
reviewed
Jan 26, 2026
| } | ||
|
|
||
| @Test | ||
| public void testGetHeaderReturnsNullWhenNoHeaders() { |
Collaborator
There was a problem hiding this comment.
i dont think these tests need to be public?
| @@ -0,0 +1,86 @@ | ||
| # Code Quality Improvement Plan |
Collaborator
There was a problem hiding this comment.
should we be committing these types of files?
Member
Author
There was a problem hiding this comment.
probably better as an issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.