Add prometheus-metrics-exposition-textformats to BOM#1450
Closed
technicallyjames wants to merge 1 commit intoprometheus:mainprometheus/client_java:mainfrom
technicallyjames:add-exposition-textformats-to-bomtechnicallyjames/client_java:add-exposition-textformats-to-bomCopy head branch name to clipboard
Closed
Add prometheus-metrics-exposition-textformats to BOM#1450technicallyjames wants to merge 1 commit intoprometheus:mainprometheus/client_java:mainfrom technicallyjames:add-exposition-textformats-to-bomtechnicallyjames/client_java:add-exposition-textformats-to-bomCopy head branch name to clipboard
prometheus-metrics-exposition-textformats to BOM#1450technicallyjames wants to merge 1 commit intoprometheus:mainprometheus/client_java:mainfrom
technicallyjames:add-exposition-textformats-to-bomtechnicallyjames/client_java:add-exposition-textformats-to-bomCopy head branch name to clipboard
Conversation
Member
|
Thanks - I think we need a unit test so that we don't forget that in the future - I'll add that, too. |
Member
|
closed in favor of #1451 |
zeitlinger
added a commit
that referenced
this pull request
Jul 7, 2025
Replaces #1450 --------- Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Co-authored-by: James McIntyre <gh.ka3tx@simplelogin.com>
Member
Author
|
@zeitlinger Awesome. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, I noticed a reference to
prometheus-metrics-exposition-textformatson https://prometheus.github.io/client_java/exporters/formats/, but I didn't see the dependency in the BOM, so I'm adding it now.@fstab @zeitlinger @dhoard @tomwilkie Please take a look. Thanks!