Eagerly reject null label values#1335
Merged
zeitlinger merged 1 commit intoprometheus:mainprometheus/client_java:mainfrom Apr 29, 2025
benjaminp:null-label-valuesbenjaminp/client_java:null-label-valuesCopy head branch name to clipboard
Merged
Eagerly reject null label values#1335zeitlinger merged 1 commit intoprometheus:mainprometheus/client_java:mainfrom benjaminp:null-label-valuesbenjaminp/client_java:null-label-valuesCopy head branch name to clipboard
zeitlinger merged 1 commit intoprometheus:mainprometheus/client_java:mainfrom
benjaminp:null-label-valuesbenjaminp/client_java:null-label-valuesCopy head branch name to clipboard
Conversation
9b88049 to
89a8ae5
Compare
Member
|
looks good - can you add a test case? |
Scraping generally doesn't support null label values and can throw NPEs at various points. It's easiest to debug such problems at the point null is introduced. Signed-off-by: Benjamin Peterson <benjamin@engflow.com>
89a8ae5 to
824da7a
Compare
Contributor
Author
|
Thank you for the review. Test added |
Member
|
thanks for the contribution |
dao-jun
pushed a commit
to dao-jun/client_java
that referenced
this pull request
May 15, 2025
Scraping generally doesn't support null label values and can throw NPEs at various points. It's easiest to debug such problems at the point null is introduced. Signed-off-by: Benjamin Peterson <benjamin@engflow.com> Signed-off-by: Benjamin Peterson <benjamin@engflow.com> Signed-off-by: dao-jun <daojun@apache.org>
dao-jun
pushed a commit
to dao-jun/client_java
that referenced
this pull request
May 15, 2025
Scraping generally doesn't support null label values and can throw NPEs at various points. It's easiest to debug such problems at the point null is introduced. Signed-off-by: Benjamin Peterson <benjamin@engflow.com> Signed-off-by: Benjamin Peterson <benjamin@engflow.com> Signed-off-by: dao-jun <daojun@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scraping generally doesn't support null label values and can throw NPEs at various points. It's easiest to debug such problems at the point null is introduced.
Signed-off-by: Benjamin Peterson benjamin@engflow.com