Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix timestamp representation#1292

Merged
zeitlinger merged 5 commits intomainprometheus/client_java:mainfrom
decimalprometheus/client_java:decimalCopy head branch name to clipboard
Apr 15, 2025
Merged

fix timestamp representation#1292
zeitlinger merged 5 commits intomainprometheus/client_java:mainfrom
decimalprometheus/client_java:decimalCopy head branch name to clipboard

Conversation

@zeitlinger
Copy link
Member

Fixes #1277

@zeitlinger zeitlinger self-assigned this Feb 27, 2025
@zeitlinger
Copy link
Member Author

@dhoard @fstab

this changes quite a lot - am I on the wrong track?

E.g. this would change in ExpositionFormatsTest:

image

@dhoard
Copy link
Collaborator

dhoard commented Feb 28, 2025

It feels like the correct approach to me.

@zeitlinger
Copy link
Member Author

Note: this change should only affect prom format - not openmetrics - see https://github.com/prometheus/OpenMetrics/blob/main/specification/OpenMetrics.md#timestamps

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger merged commit 61ae816 into main Apr 15, 2025
4 checks passed
@zeitlinger zeitlinger deleted the decimal branch April 15, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextFormatUtil.writeTimestamp writes a value with a decimal point but the spec specifies an int64

2 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.