Add documentation pages for Caffeine and Guava cache instrumentation libraries#1262
Merged
zeitlinger merged 2 commits intoprometheus:mainprometheus/client_java:mainfrom Jan 21, 2025
jhominal:cache-instrumentation-documentationjhominal/prometheus_client_java:cache-instrumentation-documentationCopy head branch name to clipboard
Merged
Add documentation pages for Caffeine and Guava cache instrumentation libraries#1262zeitlinger merged 2 commits intoprometheus:mainprometheus/client_java:mainfrom jhominal:cache-instrumentation-documentationjhominal/prometheus_client_java:cache-instrumentation-documentationCopy head branch name to clipboard
zeitlinger merged 2 commits intoprometheus:mainprometheus/client_java:mainfrom
jhominal:cache-instrumentation-documentationjhominal/prometheus_client_java:cache-instrumentation-documentationCopy head branch name to clipboard
Conversation
…libraries Signed-off-by: Jean Hominal <jhominal@gmail.com>
Member
Contributor
Author
|
@zeitlinger yes, I will do that later today :) |
Member
|
thanks for the contribution 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After working on #1251, I think that the proposed changes would warrant some kind of notice in the project documentation, and in order to do that I thought it would be cleaner to write a documentation page for caffeine instrumentation to serve as a baseline.
As the guava cache instrumentation is very similar to caffeine, I decided to write a similar documentation page for guava.