Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 5fcce84

Browse filesBrowse files
SteveSandersonMSSteveSandersonMS
committed
Workaround to fix aspnet#235 (add placeholder inside node_modules)
1 parent 1f21689 commit 5fcce84
Copy full SHA for 5fcce84

File tree

Expand file treeCollapse file tree

11 files changed

+63
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

11 files changed

+63
-6
lines changed
Open diff view settings
Collapse file

‎.gitignore‎

Copy file name to clipboardExpand all lines: .gitignore
+8-1Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@ npm-debug.log
3434
# files with that name (https://github.com/npm/npm/issues/1862). So, each template instead has a template_gitignore
3535
# file which gets renamed after the files are copied. And so any files that need to be excluded in the source
3636
# repo have to be excluded here.
37-
/templates/*/node_modules/
37+
38+
# Note that we need to exclude node_modules/** (i.e., subdirs, not the whole of node_modules) because we do need to
39+
# include the _placeholder.txt files, and can't do that using gitignore exclusion because developers aren't promoted to
40+
# commit files included that way. This is all a workaround for Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
41+
/templates/*/node_modules/**
3842
/templates/*/wwwroot/dist/
3943
.vscode/
44+
45+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
46+
!/templates/*/node_modules/_placeholder.txt
Collapse file

‎templates/Angular2Spa/node_modules/_placeholder.txt‎

Copy file name to clipboardExpand all lines: templates/Angular2Spa/node_modules/_placeholder.txt
+7Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Collapse file

‎templates/Angular2Spa/template_gitignore‎

Copy file name to clipboardExpand all lines: templates/Angular2Spa/template_gitignore
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,12 @@ ClientBin/
184184
*.dbproj.schemaview
185185
*.pfx
186186
*.publishsettings
187-
node_modules/
188187
orleans.codegen.cs
189188

189+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
190+
/node_modules/**
191+
!/node_modules/_placeholder.txt
192+
190193
# RIA/Silverlight projects
191194
Generated_Code/
192195

Collapse file

‎templates/KnockoutSpa/node_modules/_placeholder.txt‎

Copy file name to clipboardExpand all lines: templates/KnockoutSpa/node_modules/_placeholder.txt
+7Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Collapse file

‎templates/KnockoutSpa/template_gitignore‎

Copy file name to clipboardExpand all lines: templates/KnockoutSpa/template_gitignore
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,12 @@ ClientBin/
184184
*.dbproj.schemaview
185185
*.pfx
186186
*.publishsettings
187-
node_modules/
188187
orleans.codegen.cs
189188

189+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
190+
/node_modules/**
191+
!/node_modules/_placeholder.txt
192+
190193
# RIA/Silverlight projects
191194
Generated_Code/
192195

Collapse file

‎templates/ReactReduxSpa/node_modules/_placeholder.txt‎

Copy file name to clipboardExpand all lines: templates/ReactReduxSpa/node_modules/_placeholder.txt
+7Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Collapse file

‎templates/ReactReduxSpa/template_gitignore‎

Copy file name to clipboardExpand all lines: templates/ReactReduxSpa/template_gitignore
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,12 @@ ClientBin/
184184
*.dbproj.schemaview
185185
*.pfx
186186
*.publishsettings
187-
node_modules/
188187
orleans.codegen.cs
189188

189+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
190+
/node_modules/**
191+
!/node_modules/_placeholder.txt
192+
190193
# RIA/Silverlight projects
191194
Generated_Code/
192195

Collapse file

‎templates/ReactSpa/node_modules/_placeholder.txt‎

Copy file name to clipboardExpand all lines: templates/ReactSpa/node_modules/_placeholder.txt
+7Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Collapse file

‎templates/ReactSpa/template_gitignore‎

Copy file name to clipboardExpand all lines: templates/ReactSpa/template_gitignore
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,12 @@ ClientBin/
184184
*.dbproj.schemaview
185185
*.pfx
186186
*.publishsettings
187-
node_modules/
188187
orleans.codegen.cs
189188

189+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
190+
/node_modules/**
191+
!/node_modules/_placeholder.txt
192+
190193
# RIA/Silverlight projects
191194
Generated_Code/
192195

Collapse file

‎templates/WebApplicationBasic/node_modules/_placeholder.txt‎

Copy file name to clipboardExpand all lines: templates/WebApplicationBasic/node_modules/_placeholder.txt
+7Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.