Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Ενημέρωση ή προσθήκη .asc αρχείων σε όλο το βιβλίο#68

Merged
marrinosnis merged 72 commits intoprogit2-gr:masterprogit2-gr/progit2:masterfrom
marrinosnis:update-or-add-new-asc-filesmarrinosnis/progit2:update-or-add-new-asc-filesCopy head branch name to clipboard
Oct 24, 2025
Merged

Ενημέρωση ή προσθήκη .asc αρχείων σε όλο το βιβλίο#68
marrinosnis merged 72 commits intoprogit2-gr:masterprogit2-gr/progit2:masterfrom
marrinosnis:update-or-add-new-asc-filesmarrinosnis/progit2:update-or-add-new-asc-filesCopy head branch name to clipboard

Conversation

@marrinosnis
Copy link
Collaborator

@marrinosnis marrinosnis commented Sep 3, 2025

Σε αυτό το pull request θα γίνουν όλες οι απαραίτητες αλλαγές στα .asc αρχεία, ώστε να είναι στην ίδια μορφή όπως στο βιβλίο στην Αγγλική έκδοση

schacon and others added 30 commits September 30, 2014 15:57
Resolve any remaining conflicts in the files that were additionally changed
… can only be used when doctype is book"

this commit for these files should be revisited in future. It may appears due to Greek language because the UTF-8 encoding it's uses. Needs more investigation
@marrinosnis marrinosnis force-pushed the update-or-add-new-asc-files branch from f995c06 to a8d56a0 Compare September 30, 2025 21:27
@marrinosnis
Copy link
Collaborator Author

Hello @jnavila . I have completed the whole revision of the book. I have fixed typos, add files, remove deprecated ones, and in general bring the Greek version of the book, just like the English one. I am able to build it locally and produce all compiled kinds of the book (.zip, .pdf, .epub, .html).

I noticed, when I tried to build the English version, that there are some broken links, that point nowhere. At the end of the building step for .pdf version, it shows the failed ones.
Is that really a problem?

And also, which maintainers should I inform in order to pull in the new changes of the Greek version of the book ?

@jnavila jnavila requested a review from csaragiotis October 5, 2025 21:19
@marrinosnis
Copy link
Collaborator Author

Hello @jnavila. I checked that @saragiotis has not been active since May of 2024.
Is it possible to ask for review from other member, like @papantonis ?

@jnavila jnavila requested review from papantonis and removed request for csaragiotis October 12, 2025 19:41
@jnavila
Copy link
Member

jnavila commented Oct 12, 2025

Let's give it one week. If nothing happens, I'll transfer push rights to you.

@marrinosnis
Copy link
Collaborator Author

Ok. Thanks.

@papantonis
Copy link
Member

Sorry for not replying here, I'll have a look asap @marrinosnis!

@marrinosnis
Copy link
Collaborator Author

Ok @papantonis . If you have any questions, please don't hesitate to contact me.

@marrinosnis
Copy link
Collaborator Author

Hello @papantonis . Any updates on this PR ?

@papantonis
Copy link
Member

Hi again!
I had a look at most of the changes, I did not find any grammatical/syntactical issues.
Generated the book locally as well, looks beautiful, great job!

My only comment would be on the number of commits, but they do follow a logical order.

I invited you to the organization, so you must be able to push it.

@marrinosnis
Copy link
Collaborator Author

Hi @papantonis . Thanks for your input and for your review. I will try to squash some commits (the ones that are the most similar) in order to reduce the number of them. Definitely leave the ones that are crucial for the generation/build of the book for future reference and for debugging purposes

Thanks again for your time and your effort.

@marrinosnis marrinosnis merged commit 705b8ad into progit2-gr:master Oct 24, 2025
@marrinosnis marrinosnis mentioned this pull request Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.