Error when describing the Smart Protocol?#1413
Merged
ben merged 4 commits intoprogit:masterprogit/progit2:masterfrom Apr 8, 2020
Merged
Error when describing the Smart Protocol?#1413ben merged 4 commits intoprogit:masterprogit/progit2:masterfrom
ben merged 4 commits intoprogit:masterprogit/progit2:masterfrom
Conversation
Contributor
Author
|
Also modified the text to say 'chunk' rather than 'line'. This is more accurate, as a chunk can have multiple lines of data, and may not have a trailing linefeed. |
ben
reviewed
Apr 7, 2020
Member
ben
left a comment
There was a problem hiding this comment.
Heyyy this is a much better way of putting that, thanks! Just one formatting change to make.
Contributor
Author
|
Resolved, thanks for pointing out! |
Member
|
✨ thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It currently says (emphasis mine):
This is inconsistent with the examples; the length seems to include its own 4 characters, and the linefeed: