1-Liner: Allow registering new notice types #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a project of mine I wanted to use a `NoticeSuccess` type to show success-alerts on the frontend. This works as I would expect (create a child class of Notice and return 'success' in the getName() method), but a notice is throwing at this line, that `$this->_notices['success']` is undefined. My proposed change would not alter the functionality but would get rid of the notice, as `empty()`, just like `isset()`, does not throw a warning when the key is undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project of mine I wanted to use a
NoticeSuccesstype to show success-alerts on the frontend. This works as I would expect (create a child class of Notice and return 'success' in the getName() method), but a PHP Notice is thrown at the line I modified.It warns that
$this->_notices['success']is undefined.My proposed change would not alter the functionality but would get rid of the notice, as
empty(), just likeisset(), does not throw a warning when the key is undefined.