Allow $page()->addable() to be called with a template or template name #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it seems awkward to check if a user is allowed to create a page of a specific template under a specific parent. It seems one is supposed to do this?
Maybe there is an easier way that I’m unaware of. This proposal would simplify the API to:
Which I find quite legible. I must admit I don’t fully understand all implications of this change because I got lost in
User::hasPermission()
, where the argument eventually ends up in multi-language environments. It’s possible to callUser::hasPermission()
with a template as well as a page, so it won’t throw, but it takes different branches my feeble mind can’t follow.I noticed that
page()->addable()
may returntrue
if the argument is invalid or doesn’t exist. Is this by design? My first code block would returntrue
if there was no template called 'comment'. I’ve added a comment with a suggestion that would returnfalse
instead.Thank you!