Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add maximize() method. Fixes #4181. #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
Loading
from
Open

Conversation

GKFX
Copy link
Contributor

@GKFX GKFX commented May 18, 2016

As there doesn't seem to be an easy way to predict the maximized window's content size across platforms and renderers (you can get it with the window decoration included, but not easily without), the animation thread is blocked from starting until the window has actually maximized, and the correct content size has been established. This means that width and height have their correct values in setup().
If the user picks a renderer that doesn't support this, the sketch will start normally after a 2500ms delay, and they'll see an error message, naming their renderer as the culprit. The code for the JavaFX renderer is hacky; there just doesn't seem to be a better way.
Fixes #4181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.