-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix for #2944 sketchbook updates properly without restarting on all occasions #3178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Conflicts: app/src/processing/app/contrib/ContributionPanel.java app/src/processing/app/syntax/JEditTextArea.java build/macosx/appbundler.jar build/macosx/appbundler/native/main.m core/src/processing/core/PGraphics.java core/todo.txt java/src/processing/mode/java/pdex/JavaTextAreaPainter.java todo.txt
Conflicts: app/src/processing/app/Mode.java app/src/processing/app/PreferencesFrame.java app/src/processing/app/Sketch.java app/src/processing/app/contrib/ContributionListing.java app/src/processing/app/contrib/ContributionManager.java app/src/processing/app/contrib/ContributionManagerDialog.java app/src/processing/app/contrib/ContributionPanel.java app/src/processing/app/contrib/LocalContribution.java app/src/processing/app/syntax/JEditTextArea.java build/macosx/appbundler.jar build/macosx/appbundler/native/main.m core/src/processing/core/PGraphics.java core/todo.txt java/src/processing/mode/java/pdex/JavaTextAreaPainter.java todo.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These classes were removed from the source, please don't add them back again.
|
Corrected the changes as needed. Have a look if everything is okay. I had one more doubt in mind. While working on the sketchbook refresh issue, i discovered this. In preferences if you set your sketchbook folder to some folder having large number of files (for examples sake say i set it to D: (d-drive)), then it take a lot of time for the PDE to load. That is because the addSketches method is called recursively on the directory to check if a subfolder of this folder contains sketch. Can this be called an issue? |
|
Yes, so now you understand why we don't reload the entire sketchbook whenever a file is saved or renamed. A related issue: #2945 On new/rename/save as, only the portion of the sketchbook tree that has changed (the one file) should be updated. Re-indexing the full sketchbook is way too slow (and overkill) for that situation. |
|
How about this:
(Besides, there will be other things to take care of) Has this been already thought of before? or is there some point i am missing regarding the working of the code? |
|
That's much too complicated, and we have always gone out of our way to avoid adding extra metadata or properties files to the sketch folder. If people want Eclipse, they should use Eclipse. There are three things here:
#1 is a very high priority. #2 is nice to have. #3 is also a lower priority. |
Conflicts: app/src/processing/app/Mode.java app/src/processing/app/PreferencesFrame.java app/src/processing/app/Sketch.java build/macosx/appbundler.jar build/shared/lib/defaults.txt build/shared/lib/languages/PDE_de.properties build/shared/lib/languages/PDE_es.properties todo.txt
Signed-off-by: JayDusara <dusara39@gmail.com>
|
Closing this one since it's out of date, it mixes several of the issues at hand (see my last comment), and also includes quite a bit of code that's not related (language, core, and even todo.txt edits). |
Sketchbook updates automatically when new sketch is saved or when renamed.
Also if the main sketch is deleted from outside the processing window, the user can press SPACE to refresh and reflect changes.
Also, if the working directory is changed in Preferences window, the tree is updated and shows the sketches in the new directory.