Fix Android mode support on MacOS X#2525
Closed
jasstrong wants to merge 2 commits intoprocessing:masterprocessing/processing:masterfrom
Closed
Fix Android mode support on MacOS X#2525jasstrong wants to merge 2 commits intoprocessing:masterprocessing/processing:masterfrom
jasstrong wants to merge 2 commits intoprocessing:masterprocessing/processing:masterfrom
Conversation
The change in 2.2 to using the Oracle appbundler means that javac is no longer available, and copying it in from outside leads to the Android SDK utilities breaking (pre-dexing hangs, or javac hangs, or it builds a broken Android apk that doesn't run.)
Stub out the setIcon(Frame f) method on Toolkit so that the four or five modes that use it don't NoSuchMethodError on them.
Contributor
|
Shouldn't this issue being fixed in the android mode? Furthermore, the intention was to ship Processing with a clean jre without extensions. |
Contributor
|
Please use the Android repository: https://github.com/processing/processing-android This sort of fix needs to be handled in a broader way so that it's covered across all platforms. It's a bit of work and I haven't had time to do it, but we hope that it can happen during GSoC. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in 2.2 to using the Oracle appbundler means that javac is no
longer available, and copying it in from outside leads to the Android
SDK utilities breaking (pre-dexing hangs, or javac hangs, or it builds
a broken Android apk that doesn't run.)
This change adds back in the javac from the JDK that Android mode needs,
and avoids breaking the Android SDK utilities in the process.
The changes to the Toolkit.setIcon() method also broke a bunch of modes, in
particular the Permissions dialog in which one could select permissions for the
AndroidManifest. This change stubs out the setIcon(Frame f) method, letting
them run again.