Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Only add directories to libraryLocationsInAppDir that contain .so files #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
probonopd wants to merge 2 commits into
base: master
Choose a base branch
Loading
from
Draft

Only add directories to libraryLocationsInAppDir that contain .so files #316

probonopd wants to merge 2 commits into from

Conversation

@probonopd
Copy link
Owner

@probonopd probonopd commented Nov 29, 2024

Closes #314

@probonopd probonopd mentioned this pull request Nov 29, 2024
Open
@github-actions
Copy link

github-actions bot commented Nov 29, 2024

Build for testing:
artifacts
Use at your own risk.

@brunvonlope
Copy link
Contributor

brunvonlope commented Nov 29, 2024

Downloading the artifact. For some reason download speed is at 80Kbps

@probonopd
Copy link
Owner Author

probonopd commented Nov 29, 2024

Download is much faster here, maybe cancel and try again?

@brunvonlope
Copy link
Contributor

brunvonlope commented Nov 29, 2024

Hmmm, I could download it clicking on the link but didn't succeeded to download the artifacts from CLI with wget. I need to do this to be able to test on GitLab CI

@probonopd
Copy link
Owner Author

probonopd commented Nov 29, 2024 •
edited
Loading

GitHub only gives artifacts downloads to logged in users. Hence I uploaded it here. Try this:

appimagetool-856-x86_64.zip

@brunvonlope
Copy link
Contributor

brunvonlope commented Nov 29, 2024

It fails with the following error:

ERROR ReadDir: open /builds/GNOME/gimp/AppDir/usr/lib/llvm-14/lib: no such file or directory

Full log: https://gitlab.gnome.org/GNOME/gimp/-/jobs/4528193

Sorry for the huge delay, our infra is in a transition phase.

@github-actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited by probonopd
Loading

Build for testing:
artifacts
Use at your own risk.

Link that should work without login:
appimagetool-859-x86_64.zip

@brunvonlope
Copy link
Contributor

brunvonlope commented Nov 29, 2024

According to the logs (https://gitlab.gnome.org/GNOME/gimp/-/jobs/4528886), only lib/arch_triplet and lib64 are inserted in RPATH, so the situation gets worse with the patch because it can't find any other dir.

@probonopd
Copy link
Owner Author

probonopd commented Nov 29, 2024

Argh. I need a local test case... Sorry for the noise!

@probonopd probonopd marked this pull request as draft November 29, 2024 19:31
@brunvonlope brunvonlope mentioned this pull request Jun 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Executables are treated as libraries to set RPATH

3 participants

@probonopd @brunvonlope
Morty Proxy This is a proxified and sanitized view of the page, visit original site.