Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 196de0f

Browse filesBrowse files
emilybrickfrancinelucca
emilybrick
and
francinelucca
authored
Fix spacing for SelectPanel header on modal to better align with x button (#5962)
Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
1 parent 5cb35f3 commit 196de0f
Copy full SHA for 196de0f

File tree

38 files changed

+9
-0
lines changed
Filter options

38 files changed

+9
-0
lines changed

‎.changeset/long-boats-swim.md

Copy file name to clipboard
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react': patch
3+
---
4+
5+
Fix spacing for SelectPanel header on modal to better align with x button

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-colorblind-linux.png

Copy file name to clipboard
-35 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-colorblind-modern-action-list--true-linux.png

Copy file name to clipboard
-37 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-dimmed-linux.png

Copy file name to clipboard
-26 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-dimmed-modern-action-list--true-linux.png

Copy file name to clipboard
-37 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-high-contrast-linux.png

Copy file name to clipboard
-27 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-high-contrast-modern-action-list--true-linux.png

Copy file name to clipboard
-37 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-linux.png

Copy file name to clipboard
-32 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-modern-action-list--true-linux.png

Copy file name to clipboard
-35 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-tritanopia-linux.png

Copy file name to clipboard
-35 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-dark-tritanopia-modern-action-list--true-linux.png

Copy file name to clipboard
-37 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-light-colorblind-linux.png

Copy file name to clipboard
-23 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-light-colorblind-modern-action-list--true-linux.png

Copy file name to clipboard
-18 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-light-high-contrast-linux.png

Copy file name to clipboard
-18 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-light-high-contrast-modern-action-list--true-linux.png

Copy file name to clipboard
-18 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-light-linux.png

Copy file name to clipboard
-23 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-light-modern-action-list--true-linux.png

Copy file name to clipboard
-18 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-light-tritanopia-linux.png

Copy file name to clipboard
-23 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Multi-Select-Modal-light-tritanopia-modern-action-list--true-linux.png

Copy file name to clipboard
-18 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-colorblind-linux.png

Copy file name to clipboard
-33 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-colorblind-modern-action-list--true-linux.png

Copy file name to clipboard
-39 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-dimmed-linux.png

Copy file name to clipboard
-32 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-dimmed-modern-action-list--true-linux.png

Copy file name to clipboard
-33 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-high-contrast-linux.png

Copy file name to clipboard
-32 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-high-contrast-modern-action-list--true-linux.png

Copy file name to clipboard
-32 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-linux.png

Copy file name to clipboard
-31 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-modern-action-list--true-linux.png

Copy file name to clipboard
-35 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-tritanopia-linux.png

Copy file name to clipboard
-33 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-dark-tritanopia-modern-action-list--true-linux.png

Copy file name to clipboard
-39 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-light-colorblind-linux.png

Copy file name to clipboard
-17 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-light-colorblind-modern-action-list--true-linux.png

Copy file name to clipboard
-25 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-light-high-contrast-linux.png

Copy file name to clipboard
-16 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-light-high-contrast-modern-action-list--true-linux.png

Copy file name to clipboard
-21 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-light-linux.png

Copy file name to clipboard
-17 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-light-modern-action-list--true-linux.png

Copy file name to clipboard
-24 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-light-tritanopia-linux.png

Copy file name to clipboard
-17 Bytes
Loading

‎.playwright/snapshots/components/SelectPanel.test.ts-snapshots/SelectPanel-Single-Select-Modal-light-tritanopia-modern-action-list--true-linux.png

Copy file name to clipboard
-25 Bytes
Loading

‎packages/react/src/SelectPanel/SelectPanel.module.css

Copy file name to clipboardExpand all lines: packages/react/src/SelectPanel/SelectPanel.module.css
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@
2424
font-size: var(--text-body-size-medium);
2525
}
2626

27+
.Wrapper[data-variant='modal'] .Title {
28+
margin-top: var(--base-size-8); /* styling specific to the modal variant */
29+
}
30+
2731
.Subtitle {
2832
margin-left: var(--base-size-8);
2933
font-size: var(--text-body-size-small);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.