Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Jts blocks mini test#210

Closed
johnschoeman wants to merge 1 commit intoprettier:masterprettier/plugin-ruby:masterfrom
johnschoeman:jts-blocks-mini-testjohnschoeman/plugin-ruby:jts-blocks-mini-testCopy head branch name to clipboard
Closed

Jts blocks mini test#210
johnschoeman wants to merge 1 commit intoprettier:masterprettier/plugin-ruby:masterfrom
johnschoeman:jts-blocks-mini-testjohnschoeman/plugin-ruby:jts-blocks-mini-testCopy head branch name to clipboard

Conversation

@johnschoeman
Copy link
Contributor

Add minitests for blocks.rb …
Why:
We would like for the blocks.rb file for the test snapshots to also be a
minitest test so that we can run the ruby tests after the prettier
formatting process an validate that the assignments are equivalent post
formatting.

this commit:
Introduces minitest to '/test/cases/blocks.rb'

issue: #120

@johnschoeman
Copy link
Contributor Author

Note that this should be based off of #209

Why:
We would like for the blocks.rb file for the test snapshots to also be a
minitest test so that we can run the ruby tests after the prettier
formatting process an validate that the assignments are equivalent post
formatting.

this commit:
Introduces minitest to '/test/cases/blocks.rb'

issue: [prettier#120](prettier#120)
@johnschoeman johnschoeman force-pushed the jts-blocks-mini-test branch from 312d8e0 to 4edb230 Compare March 29, 2019 17:33
@johnschoeman
Copy link
Contributor Author

Made the changes to rebase this off master instead of #209

@kddnewton kddnewton mentioned this pull request Apr 13, 2019
@kddnewton
Copy link
Member

Again thanks for this. Going to close now that the big tests refactor is merged.

@kddnewton kddnewton closed this Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.