Fix LegacySongProgress position when reapplying the skin during gameplay#37627
Open
curoviyxru wants to merge 3 commits intoppy:masterppy/osu:masterfrom
curoviyxru:fix-legacy-progress-positioncuroviyxru/osu:fix-legacy-progress-positionCopy head branch name to clipboard
Open
Fix LegacySongProgress position when reapplying the skin during gameplay#37627curoviyxru wants to merge 3 commits intoppy:masterppy/osu:masterfrom curoviyxru:fix-legacy-progress-positioncuroviyxru/osu:fix-legacy-progress-positionCopy head branch name to clipboard
LegacySongProgress position when reapplying the skin during gameplay#37627curoviyxru wants to merge 3 commits intoppy:masterppy/osu:masterfrom
curoviyxru:fix-legacy-progress-positioncuroviyxru/osu:fix-legacy-progress-positionCopy head branch name to clipboard
Conversation
Member
|
This all seems really hacky. Can we just make the progress at a fixed position and call it a day? |
…tion is determined" This reverts commit c541f07.
LegacySongProgress position when reapplying the skin during gameplay
peppy
reviewed
May 5, 2026
| } | ||
| } | ||
|
|
||
| public static float GetAccuracyCounterMaxWidth(this ISkin source) |
Member
There was a problem hiding this comment.
Okay this is just getting silly now.
Are you writing this code yourself?
Contributor
Author
There was a problem hiding this comment.
Yeah. If that doesn't work, I have no idea how to fix this other than loading a separate LegacyAccuracyCounter or LegacySpriteText just for that. But is it really a less hacky way?
How is it possible to make the progress at a fixed position if it depends on accuracy counter's font sprites size and font overlap?
Will assume that I've missed something in the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37559.