Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 41e6324

Browse filesBrowse files
arssherarssher
committed
Using MODULES for building .so instead of MODULE_big.
This is fix of my previous commit 1443ae0. PGXS supports two ways of building shared libraries: building an so for each module specified in MODULES and building one big so named MODULE_big for all modules specified in OBJS. Previously this extension used the latter, but also specified MODULES variable for no reason, which is pretty strange. Since extension contains just one module, it is sane to use the former. I have removed OBJS variable, but forgot to remove MODULE_big in my previous commit, which broke the build, since an empty so was assembled. This commit fixes the issue. Besides, PG_CONFIG var is now consulted for path to pg_config, which allows to build extension without pg_config in the PATH.
1 parent 8158b1a commit 41e6324
Copy full SHA for 41e6324

File tree

1 file changed

+4
-3
lines changed
Filter options

1 file changed

+4
-3
lines changed

‎Makefile

Copy file name to clipboard
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
EXTENSION = zson
22
MODULES = zson
33
DATA = zson--1.1.sql zson--1.0--1.1.sql
4-
OBJS = zson.o
54
REGRESS = zson
65

7-
MODULE_big = zson
86
PG_CPPFLAGS = -g -O2
97
SHLIB_LINK = # -lz -llz4
108

11-
PGXS := $(shell pg_config --pgxs)
9+
ifndef PG_CONFIG
10+
PG_CONFIG := pg_config
11+
endif
12+
PGXS := $(shell $(PG_CONFIG) --pgxs)
1213
include $(PGXS)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.