postgrespro
diff --git a/‎collector.c
Copy file name to clipboardExpand all lines: collector.c
+4-1Lines changed: 4 additions & 1 deletion b/‎collector.c
Copy file name to clipboardExpand all lines: collector.c
+4-1Lines changed: 4 additions & 1 deletion
diff --git a/‎pg_wait_sampling.c
Copy file name to clipboardExpand all lines: pg_wait_sampling.c
+8-2Lines changed: 8 additions & 2 deletions b/‎pg_wait_sampling.c
Copy file name to clipboardExpand all lines: pg_wait_sampling.c
+8-2Lines changed: 8 additions & 2 deletions
@@ -131,6 +131,7 @@ get_next_observation(History *observations)
 {
 	HistoryItem *result;
 
+	/* Check for wraparound */
 	if (observations->index >= observations->count)
 	{
 		observations->index = 0;
@@ -217,6 +218,7 @@ send_history(History *observations, shm_mq_handle *mqh)
 	else
 		count = observations->index;
 
+	/* Send array size first since receive_array expects this */
 	mq_result = shm_mq_send_compat(mqh, sizeof(count), &count, false, true);
 	if (mq_result == SHM_MQ_DETACHED)
 	{
@@ -253,6 +255,7 @@ send_profile(HTAB *profile_hash, shm_mq_handle *mqh)
 	Size		count = hash_get_num_entries(profile_hash);
 	shm_mq_result mq_result;
 
+	/* Send array size first since receive_array expects this */
 	mq_result = shm_mq_send_compat(mqh, sizeof(count), &count, false, true);
 	if (mq_result == SHM_MQ_DETACHED)
 	{
@@ -380,7 +383,7 @@ pgws_collector_main(Datum main_arg)
 			ProcessConfigFile(PGC_SIGHUP);
 		}
 
-		/* Wait calculate time to next sample for history or profile */
+		/* Calculate time to next sample for history or profile */
 		current_ts = GetCurrentTimestamp();
 
 		history_diff = millisecs_diff(history_ts, current_ts);
 
@@ -44,7 +44,7 @@ void		_PG_init(void);
 
 static bool shmem_initialized = false;
 
-/* Hooks */
+/* Hooks variables */
 static ExecutorStart_hook_type prev_ExecutorStart = NULL;
 static ExecutorRun_hook_type prev_ExecutorRun = NULL;
 static ExecutorFinish_hook_type prev_ExecutorFinish = NULL;
@@ -65,6 +65,7 @@ static shm_mq *recv_mq = NULL;
 static shm_mq_handle *recv_mqh = NULL;
 static LOCKTAG queueTag;
 
+/* Hook functions */
 #if PG_VERSION_NUM >= 150000
 static shmem_request_hook_type prev_shmem_request_hook = NULL;
 #endif
@@ -126,7 +127,6 @@ static const struct config_enum_entry pgws_profile_queries_options[] =
 	{NULL, 0, false}
 };
 
-/* GUC variables */
 int			pgws_historySize = 5000;
 int			pgws_historyPeriod = 10;
 int			pgws_profilePeriod = 10;
@@ -253,6 +253,7 @@ pgws_shmem_startup(void)
 
 	if (!found)
 	{
+		/* Create shared objects */
 		toc = shm_toc_create(PG_WAIT_SAMPLING_MAGIC, pgws, segsize);
 
 		pgws_collector_hdr = shm_toc_allocate(toc, sizeof(CollectorShmqHeader));
@@ -266,6 +267,7 @@ pgws_shmem_startup(void)
 	}
 	else
 	{
+		/* Attach to existing shared objects */
 		toc = shm_toc_attach(PG_WAIT_SAMPLING_MAGIC, pgws);
 		pgws_collector_hdr = shm_toc_lookup(toc, 0, false);
 		pgws_collector_mq = shm_toc_lookup(toc, 1, false);
@@ -522,6 +524,7 @@ pg_wait_sampling_get_current(PG_FUNCTION_ARGS)
 
 		if (!PG_ARGISNULL(0))
 		{
+			/* pg_wait_sampling_get_current(pid int4) function */
 			HistoryItem *item;
 			PGPROC	   *proc;
 
@@ -535,6 +538,7 @@ pg_wait_sampling_get_current(PG_FUNCTION_ARGS)
 		}
 		else
 		{
+			/* pg_wait_sampling_current view */
 			int			procCount = ProcGlobal->allProcCount,
 						i,
 						j = 0;
@@ -600,6 +604,7 @@ pg_wait_sampling_get_current(PG_FUNCTION_ARGS)
 	}
 	else
 	{
+		/* nothing left */
 		SRF_RETURN_DONE(funcctx);
 	}
 }
@@ -621,6 +626,7 @@ pgws_init_lock_tag(LOCKTAG *tag, uint32 lock)
 	tag->locktag_lockmethodid = USER_LOCKMETHOD;
 }
 
+/* Get array (history or profile data) from shared memory */
 static void *
 receive_array(SHMRequest request, Size item_size, Size *count)
 {
Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ get_next_observation(History *observations)`
`131`	`131`	`{`
`132`	`132`	`HistoryItem *result;`
`133`	`133`
	`134`	`+ /* Check for wraparound */`
`134`	`135`	`if (observations->index >= observations->count)`
`135`	`136`	`{`
`136`	`137`	`observations->index = 0;`
`@@ -217,6 +218,7 @@ send_history(History observations, shm_mq_handle mqh)`
`217`	`218`	`else`
`218`	`219`	`count = observations->index;`
`219`	`220`
	`221`	`+ /* Send array size first since receive_array expects this */`
`220`	`222`	`mq_result = shm_mq_send_compat(mqh, sizeof(count), &count, false, true);`
`221`	`223`	`if (mq_result == SHM_MQ_DETACHED)`
`222`	`224`	`{`
`@@ -253,6 +255,7 @@ send_profile(HTAB profile_hash, shm_mq_handle mqh)`
`253`	`255`	`Size count = hash_get_num_entries(profile_hash);`
`254`	`256`	`shm_mq_result mq_result;`
`255`	`257`
	`258`	`+ /* Send array size first since receive_array expects this */`
`256`	`259`	`mq_result = shm_mq_send_compat(mqh, sizeof(count), &count, false, true);`
`257`	`260`	`if (mq_result == SHM_MQ_DETACHED)`
`258`	`261`	`{`
`@@ -380,7 +383,7 @@ pgws_collector_main(Datum main_arg)`
`380`	`383`	`ProcessConfigFile(PGC_SIGHUP);`
`381`	`384`	`}`
`382`	`385`
`383`		`- /* Wait calculate time to next sample for history or profile */`
	`386`	`+ /* Calculate time to next sample for history or profile */`
`384`	`387`	`current_ts = GetCurrentTimestamp();`
`385`	`388`
`386`	`389`	`history_diff = millisecs_diff(history_ts, current_ts);`