Docker fix of the day #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
montanalow
reviewed
Jun 13, 2023
| @@ -1,5 +1,5 @@ | ||
| -- Exit on error (psql) | ||
| \set ON_ERROR_STOP true | ||
| -- \set ON_ERROR_STOP true |
There was a problem hiding this comment.
I think this is going to cause a problem later when we miss breakage. These are intended to be part of CI.
There was a problem hiding this comment.
SilasMarvin
pushed a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs
pgml-exensionbuild when PostgresML version changes.pgml-dashboard(extra semicolumn).setup_examples.sqlif things already exist. We have a volume now, they will fail every time the container starts up otherwise.Features
pgml-extension/Dockerfileto benefit more from Docker's layers and build things faster.