Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

xformers installation fix #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2023
Merged

xformers installation fix #731

merged 2 commits into from
Jun 13, 2023

Conversation

santiatpml
Copy link
Contributor

No description provided.

@santiatpml santiatpml requested a review from levkk June 13, 2023 03:41
@@ -18,7 +18,6 @@ torchaudio==2.0.2
torchvision==0.15.2
tqdm==4.65.0
transformers==4.29.2
xformers==0.0.20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this file to install dependencies elsewhere, e.g. in our production cloud. Would it be possible to add another file, perhaps requirements-xformers.txt to install that special package?

Copy link
Contributor

@levkk levkk Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do:

requirements-xformers.txt

xformers==0.0.20 --no-dependencies

which is then installable with

pip install -r requirements-xformers.txt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that if we put this package only in the dockerfile, we'll forget to add it elsewhere where it's needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-dependencies has to be outside requirements.txt file.
pip install -r requirements-xformers.txt --no-dependencies

@santiatpml santiatpml requested a review from levkk June 13, 2023 04:04
@santiatpml santiatpml merged commit 61603e6 into master Jun 13, 2023
@santiatpml santiatpml deleted the santi-xformers-dockerfile branch June 13, 2023 04:15
SilasMarvin pushed a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.