Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9c377b5

Browse filesBrowse files
committed
fix: add error details to the status message on failure (#130)
1 parent 16e9c0f commit 9c377b5
Copy full SHA for 9c377b5

File tree

1 file changed

+12
-12
lines changed
Filter options

1 file changed

+12
-12
lines changed

‎pkg/services/cloning/mode_base.go

Copy file name to clipboardExpand all lines: pkg/services/cloning/mode_base.go
+12-12Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,11 @@ func (c *baseCloning) CreateClone(cloneRequest *types.CloneCreateRequest) (*mode
133133
// TODO(anatoly): Empty room case.
134134
log.Errf("Failed to start session: %v.", err)
135135

136-
if err := c.updateCloneStatus(cloneID, models.Status{
136+
if updateErr := c.updateCloneStatus(cloneID, models.Status{
137137
Code: models.StatusFatal,
138-
Message: models.CloneMessageFatal,
139-
}); err != nil {
140-
log.Errf("Failed to update clone status: %v", err)
138+
Message: errors.Cause(err).Error(),
139+
}); updateErr != nil {
140+
log.Errf("Failed to update clone status: %v", updateErr)
141141
}
142142

143143
return
@@ -204,11 +204,11 @@ func (c *baseCloning) DestroyClone(cloneID string) error {
204204
if err := c.provision.StopSession(w.session); err != nil {
205205
log.Errf("Failed to delete a clone: %+v.", err)
206206

207-
if err := c.updateCloneStatus(cloneID, models.Status{
207+
if updateErr := c.updateCloneStatus(cloneID, models.Status{
208208
Code: models.StatusFatal,
209-
Message: models.CloneMessageFatal,
210-
}); err != nil {
211-
log.Errf("Failed to update clone status: %v", err)
209+
Message: errors.Cause(err).Error(),
210+
}); updateErr != nil {
211+
log.Errf("Failed to update clone status: %v", updateErr)
212212
}
213213

214214
return
@@ -284,11 +284,11 @@ func (c *baseCloning) ResetClone(cloneID string) error {
284284
if err != nil {
285285
log.Errf("Failed to reset a clone: %+v.", err)
286286

287-
if err := c.updateCloneStatus(cloneID, models.Status{
287+
if updateErr := c.updateCloneStatus(cloneID, models.Status{
288288
Code: models.StatusFatal,
289-
Message: models.CloneMessageFatal,
290-
}); err != nil {
291-
log.Errf("failed to update clone status: %v", err)
289+
Message: errors.Cause(err).Error(),
290+
}); updateErr != nil {
291+
log.Errf("failed to update clone status: %v", updateErr)
292292
}
293293

294294
return

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.