Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f2b268e

Browse filesBrowse files
author
Amit Kapila
committed
Fix memory leak in SnapBuildSerialize.
The memory for the snapshot was leaked while serializing it to disk during logical decoding. This memory will be freed only once walsender stops streaming the changes. This can lead to a huge memory increase when master logs Standby Snapshot too frequently say when the user is trying to create many replication slots. Reported-by: funnyxj.fxj@alibaba-inc.com Diagnosed-by: funnyxj.fxj@alibaba-inc.com Author: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/033ab54c-6393-42ee-8ec9-2b399b5d8cde.funnyxj.fxj@alibaba-inc.com
1 parent 594a7dc commit f2b268e
Copy full SHA for f2b268e

File tree

Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed

‎src/backend/replication/logical/snapbuild.c

Copy file name to clipboardExpand all lines: src/backend/replication/logical/snapbuild.c
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1464,7 +1464,7 @@ static void
14641464
SnapBuildSerialize(SnapBuild *builder, XLogRecPtr lsn)
14651465
{
14661466
Size needed_length;
1467-
SnapBuildOnDisk *ondisk;
1467+
SnapBuildOnDisk *ondisk = NULL;
14681468
char *ondisk_c;
14691469
int fd;
14701470
char tmppath[MAXPGPATH];
@@ -1656,6 +1656,9 @@ SnapBuildSerialize(SnapBuild *builder, XLogRecPtr lsn)
16561656
out:
16571657
ReorderBufferSetRestartPoint(builder->reorder,
16581658
builder->last_serialized_snapshot);
1659+
/* be tidy */
1660+
if (ondisk)
1661+
pfree(ondisk);
16591662
}
16601663

16611664
/*

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.