Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit e2e3b8a

Browse filesBrowse files
hlinnakahlinnaka
committed
Disable tests using injection points in installcheck
The 'gin' test injections faults to GIN index build. If another test running concurrently in the same cluster also tries to create a GIN index, it will hit the fault, too. To fix, disable tests using injection points when running against an existing cluster. A better long-term solution would be to make the injection points scoped to the database or process, but this will do for now. Discussion: https://www.postgresql.org/message-id/CA%2BhUKGJYhcG_o2nwSK6r01eOZJwNWUJUbX%3D%3DAVnW84f-%2B8yamQ@mail.gmail.com Discussion: https://www.postgresql.org/message-id/10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi
1 parent 071e3ad commit e2e3b8a
Copy full SHA for e2e3b8a

File tree

Expand file treeCollapse file tree

4 files changed

+10
-0
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+10
-0
lines changed

‎src/test/modules/gin/Makefile

Copy file name to clipboardExpand all lines: src/test/modules/gin/Makefile
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ EXTRA_INSTALL = src/test/modules/injection_points
44

55
REGRESS = gin_incomplete_splits
66

7+
# The injection points are cluster-wide, so disable installcheck
8+
NO_INSTALLCHECK = 1
9+
710
ifdef USE_PGXS
811
PG_CONFIG = pg_config
912
PGXS := $(shell $(PG_CONFIG) --pgxs)

‎src/test/modules/gin/meson.build

Copy file name to clipboardExpand all lines: src/test/modules/gin/meson.build
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,7 @@ tests += {
1212
'sql': [
1313
'gin_incomplete_splits',
1414
],
15+
# The injection points are cluster-wide, so disable installcheck
16+
'runningcheck': false,
1517
},
1618
}

‎src/test/modules/injection_points/Makefile

Copy file name to clipboardExpand all lines: src/test/modules/injection_points/Makefile
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ PGFILEDESC = "injection_points - facility for injection points"
88

99
REGRESS = injection_points
1010

11+
# The injection points are cluster-wide, so disable installcheck
12+
NO_INSTALLCHECK = 1
13+
1114
ifdef USE_PGXS
1215
PG_CONFIG = pg_config
1316
PGXS := $(shell $(PG_CONFIG) --pgxs)

‎src/test/modules/injection_points/meson.build

Copy file name to clipboardExpand all lines: src/test/modules/injection_points/meson.build
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,7 @@ tests += {
3333
'sql': [
3434
'injection_points',
3535
],
36+
# The injection points are cluster-wide, so disable installcheck
37+
'runningcheck': false,
3638
},
3739
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.