Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e1623b7

Browse filesBrowse files
committed
Fix obsolete comments referencing JoinPathExtraData.extra_lateral_rels.
That field went away in commit edca44b, but it seems that commit 45be99f re-introduced some comments mentioning it. Noted by James Coleman, though this isn't exactly his proposed new wording. Also thanks to Justin Pryzby for software archaeology. Discussion: https://postgr.es/m/CAAaqYe8fxZjq3na+XkNx4C78gDqykH-7dbnzygm9Qa9nuDTePg@mail.gmail.com
1 parent 9acaf1a commit e1623b7
Copy full SHA for e1623b7

File tree

Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed

‎src/backend/optimizer/path/joinpath.c

Copy file name to clipboardExpand all lines: src/backend/optimizer/path/joinpath.c
+5-5Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -670,8 +670,8 @@ try_partial_nestloop_path(PlannerInfo *root,
670670
/*
671671
* If the inner path is parameterized, the parameterization must be fully
672672
* satisfied by the proposed outer path. Parameterized partial paths are
673-
* not supported. The caller should already have verified that no
674-
* extra_lateral_rels are required here.
673+
* not supported. The caller should already have verified that no lateral
674+
* rels are required here.
675675
*/
676676
Assert(bms_is_empty(joinrel->lateral_relids));
677677
if (inner_path->param_info != NULL)
@@ -984,8 +984,8 @@ try_partial_hashjoin_path(PlannerInfo *root,
984984
/*
985985
* If the inner path is parameterized, the parameterization must be fully
986986
* satisfied by the proposed outer path. Parameterized partial paths are
987-
* not supported. The caller should already have verified that no
988-
* extra_lateral_rels are required here.
987+
* not supported. The caller should already have verified that no lateral
988+
* rels are required here.
989989
*/
990990
Assert(bms_is_empty(joinrel->lateral_relids));
991991
if (inner_path->param_info != NULL)
@@ -1714,7 +1714,7 @@ match_unsorted_outer(PlannerInfo *root,
17141714
* partial path and the joinrel is parallel-safe. However, we can't
17151715
* handle JOIN_UNIQUE_OUTER, because the outer path will be partial, and
17161716
* therefore we won't be able to properly guarantee uniqueness. Nor can
1717-
* we handle extra_lateral_rels, since partial paths must not be
1717+
* we handle joins needing lateral rels, since partial paths must not be
17181718
* parameterized. Similarly, we can't handle JOIN_FULL and JOIN_RIGHT,
17191719
* because they can produce false null extended rows.
17201720
*/

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.