Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit cc7ea07

Browse filesBrowse files
committed
pg_attribute_no_sanitize_alignment() macro
Modern gcc and clang compilers offer alignment sanitizers, which help to detect pointer misalignment. However, our codebase already contains x86-specific crc32 computation code, which uses unalignment access. Thankfully, those compilers also support the attribute, which disables alignment sanitizers at the function level. This commit adds pg_attribute_no_sanitize_alignment(), which wraps this attribute, and applies it to pg_comp_crc32c_sse42() function. Back-patch of commits 993bdb9 and ad2ad69, to enable doing alignment testing in all supported branches. Discussion: https://postgr.es/m/CAPpHfdsne3%3DT%3DfMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w%40mail.gmail.com Discussion: https://postgr.es/m/475514.1612745257%40sss.pgh.pa.us Author: Alexander Korotkov, revised by Tom Lane Reviewed-by: Tom Lane
1 parent f4d781d commit cc7ea07
Copy full SHA for cc7ea07

File tree

Expand file treeCollapse file tree

2 files changed

+13
-0
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+13
-0
lines changed

‎src/include/c.h

Copy file name to clipboardExpand all lines: src/include/c.h
+12Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,18 @@
139139
#define pg_attribute_unused()
140140
#endif
141141

142+
/*
143+
* Place this macro before functions that should be allowed to make misaligned
144+
* accesses. Think twice before using it on non-x86-specific code!
145+
* Testing can be done with "-fsanitize=alignment -fsanitize-trap=alignment"
146+
* on clang, or "-fsanitize=alignment -fno-sanitize-recover=alignment" on gcc.
147+
*/
148+
#if __clang_major__ >= 7 || __GNUC__ >= 8
149+
#define pg_attribute_no_sanitize_alignment() __attribute__((no_sanitize("alignment")))
150+
#else
151+
#define pg_attribute_no_sanitize_alignment()
152+
#endif
153+
142154
/*
143155
* Append PG_USED_FOR_ASSERTS_ONLY to definitions of variables that are only
144156
* used in assert-enabled builds, to avoid compiler warnings about unused

‎src/port/pg_crc32c_sse42.c

Copy file name to clipboardExpand all lines: src/port/pg_crc32c_sse42.c
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
#include <nmmintrin.h>
2020

21+
pg_attribute_no_sanitize_alignment()
2122
pg_crc32c
2223
pg_comp_crc32c_sse42(pg_crc32c crc, const void *data, size_t len)
2324
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.