Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit be7485a

Browse filesBrowse files
committed
Fix psql's ON_ERROR_ROLLBACK so that it handles COMMIT AND CHAIN.
When ON_ERROR_ROLLBACK is enabled, psql releases a temporary savepoint if it's idle in a valid transaction block after executing a query. But psql doesn't do that after RELEASE or ROLLBACK is executed because a temporary savepoint has already been destroyed in that case. This commit changes psql's ON_ERROR_ROLLBACK so that it doesn't release a temporary savepoint also when COMMIT AND CHAIN is executed. A temporary savepoint doesn't need to be released in that case because COMMIT AND CHAIN also destroys any savepoints defined within the transaction to commit. Otherwise psql tries to release the savepoint that COMMIT AND CHAIN has already destroyed and cause an error "ERROR: savepoint "pg_psql_temporary_savepoint" does not exist". Back-patch to v12 where transaction chaining was added. Reported-by: Arthur Nascimento Author: Arthur Nascimento Reviewed-by: Fujii Masao, Vik Fearing Discussion: https://postgr.es/m/16867-3475744069228158@postgresql.org
1 parent 422012c commit be7485a
Copy full SHA for be7485a

File tree

Expand file treeCollapse file tree

1 file changed

+5
-4
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-4
lines changed

‎src/bin/psql/common.c

Copy file name to clipboardExpand all lines: src/bin/psql/common.c
+5-4Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1346,12 +1346,13 @@ SendQuery(const char *query)
13461346

13471347
/*
13481348
* Do nothing if they are messing with savepoints themselves:
1349-
* If the user did RELEASE or ROLLBACK, our savepoint is gone.
1350-
* If they issued a SAVEPOINT, releasing ours would remove
1351-
* theirs.
1349+
* If the user did COMMIT AND CHAIN, RELEASE or ROLLBACK, our
1350+
* savepoint is gone. If they issued a SAVEPOINT, releasing
1351+
* ours would remove theirs.
13521352
*/
13531353
if (results &&
1354-
(strcmp(PQcmdStatus(results), "SAVEPOINT") == 0 ||
1354+
(strcmp(PQcmdStatus(results), "COMMIT") == 0 ||
1355+
strcmp(PQcmdStatus(results), "SAVEPOINT") == 0 ||
13551356
strcmp(PQcmdStatus(results), "RELEASE") == 0 ||
13561357
strcmp(PQcmdStatus(results), "ROLLBACK") == 0))
13571358
svptcmd = NULL;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.