Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b99414d

Browse filesBrowse files
committed
Remove configuration-dependent output from new inplace-inval test.
Per buildfarm members prion and trilobite. Back-patch to v12 (all supported versions), like commit 0844b39. Strategy reviewed by Tom Lane. Discussion: https://postgr.es/m/20240628051353.a0.nmisch@google.com
1 parent b48f275 commit b99414d
Copy full SHA for b99414d

File tree

Expand file treeCollapse file tree

2 files changed

+4
-10
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-10
lines changed

‎src/test/isolation/expected/inplace-inval.out

Copy file name to clipboardExpand all lines: src/test/isolation/expected/inplace-inval.out
+1-9Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Parsed test spec with 3 sessions
22

3-
starting permutation: cachefill3 cir1 cic2 ddl3 read1
3+
starting permutation: cachefill3 cir1 cic2 ddl3
44
step cachefill3: TABLE newly_indexed;
55
c
66
-
@@ -9,14 +9,6 @@ c
99
step cir1: BEGIN; CREATE INDEX i1 ON newly_indexed (c); ROLLBACK;
1010
step cic2: CREATE INDEX i2 ON newly_indexed (c);
1111
step ddl3: ALTER TABLE newly_indexed ADD extra int;
12-
step read1:
13-
SELECT relhasindex FROM pg_class WHERE oid = 'newly_indexed'::regclass;
14-
15-
relhasindex
16-
-----------
17-
f
18-
(1 row)
19-
2012

2113
starting permutation: cir1 cic2 ddl3 read1
2214
step cir1: BEGIN; CREATE INDEX i1 ON newly_indexed (c); ROLLBACK;

‎src/test/isolation/specs/inplace-inval.spec

Copy file name to clipboardExpand all lines: src/test/isolation/specs/inplace-inval.spec
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,14 @@ step cachefill3 { TABLE newly_indexed; }
2727
step ddl3 { ALTER TABLE newly_indexed ADD extra int; }
2828

2929

30+
# XXX shows an extant bug. Adding step read1 at the end would usually print
31+
# relhasindex=f (not wanted). This does not reach the unwanted behavior under
32+
# -DCATCACHE_FORCE_RELEASE and friends.
3033
permutation
3134
cachefill3 # populates the pg_class row in the catcache
3235
cir1 # sets relhasindex=true; rollback discards cache inval
3336
cic2 # sees relhasindex=true, skips changing it (so no inval)
3437
ddl3 # cached row as the oldtup of an update, losing relhasindex
35-
read1 # observe damage XXX is an extant bug
3638

3739
# without cachefill3, no bug
3840
permutation cir1 cic2 ddl3 read1

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.